feat: add external plugin to build engine #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
matt2e
force-pushed
the
matt2e/language-plugin-external
branch
6 times, most recently
from
cb777b2 to
f0ef049
Compare
38 tasks
matt2e
force-pushed
the
matt2e/language-plugin-external
branch
8 times, most recently
from
bc8e94f to
436279f
Compare
matt2e
requested review from
a team and
deniseli
and removed request for
a team
matt2e
commented
Oct 10, 2024
matt2e
force-pushed
the
matt2e/language-plugin-external
branch
from
e95d158 to
e91dea9
Compare
alecthomas
reviewed
Oct 11, 2024
alecthomas
reviewed
Oct 11, 2024
alecthomas
approved these changes
Oct 11, 2024
|
|
||
| runCtx, cancel := context.WithCancel(ctx) | ||
|
|
||
| cmdErr := make(chan error) |
There was a problem hiding this comment.
Wouldn't an errgroup be preferable here?
There was a problem hiding this comment.
I don't think it'd work, but I might be missing how to do it.
The ping channel closes when ping succeeds or fails. The cmd chan closes if the plugin exits. In normal cases the plugin won't exit until plugin.Kill() is called, but can happen early for whatever reason.
So the select is looking for whichever of those 2 happens first, not waiting for both channels.
matt2e
force-pushed
the
matt2e/language-plugin-external
branch
2 times, most recently
from
43dff70 to
8e32669
Compare
# Conflicts: # backend/protos/xyz/block/ftl/v1/language/mixins.go # Conflicts: # frontend/cli/main.go
matt2e
force-pushed
the
matt2e/language-plugin-external
branch
from
8e32669 to
352df08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
languageplugin.externalPluginfor working with plugins over gRPC. This PR does not include any non-test implementations.Part of #2452